Skip to content

Update variable mass implementation and add documentation #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtgrasb merged 2 commits into from
Jul 8, 2025
Merged

Update variable mass implementation and add documentation #1494

jtgrasb merged 2 commits into from
Jul 8, 2025

Conversation

@jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Jul 1, 2025

This PR updates the variable mass to follow the workflow:

  1. Use variable mass inputs from user.
  2. If no variable mass input but variable inertia is present in the input file, assume equilibrium and use the provided variable inertia.
  3. If no variable mass or inertia is present, use the specified body mass and inertia for all variable hydro cases.

I also added some documentation for the updated variable mass example (PR 90 on Applications).

@jtgrasb jtgrasb mentioned this pull request Jul 2, 2025
Merged
@kmruehl kmruehl added Documentation related to docs Body Class Body Class (bodyClass.m) labels Jul 7, 2025
akeeste
akeeste approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtgrasb. A couple minor suggestions to commit and then let's merge this

@jtgrasb jtgrasb merged commit 6841be8 into WEC-Sim:dev Jul 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akeeste akeeste akeeste approved these changes

Assignees

No one assigned

Labels

Body Class Body Class (bodyClass.m) Documentation related to docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtgrasb @akeeste @kmruehl