-
Notifications
You must be signed in to change notification settings - Fork 184
Refactor badBemioFix_fcn #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor badBemioFix_fcn #1489
Conversation
|
Hi @akeeste this is the citation from our European friends: Kelly, T., Zabala, I., Peña-Sanchez, Y., Penalba, M., Ringwood, J. V., Henriques, J. C., & Blanco, J. M. (2022). A post-processing technique for removing ‘irregular frequencies’ and other issues in the results from BEM solvers. International Marine Energy Journal, 5(1), 123–131. https://doi.org/10.36688/imej.5.123-131 |
|
Thanks @dforbush2 for the citation This is ready for review. I have a test script and data that I can email privately to test the PR with (TEAMER data)@dforbush2 if you have the time to review you probably know this function best, but this isn't an urgent merge so no pressure to. |
|
Note: the most recent version of BEMRosetta filters in a very similar way and can output an .h5 file that WEC-Sim can read |
|
The PR works as expected, I will go ahead and merge this PR |
This PR refactors
badBemioFix_fcn:cleanBEMinterp1for consistency and ease of changing the interpolation methodcleanBEMand fixes a couple bugs:
To compare the largely identical results after the refactor but before a few bug fixes, look at commit 381f8ba
TODO: