Skip to content

Irregular CIC test for OSWEC #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmruehl merged 3 commits into from
Jul 11, 2025
Merged

Irregular CIC test for OSWEC #1484

kmruehl merged 3 commits into from
Jul 11, 2025
+307 −13

Conversation

@jleonqu
Copy link
Contributor

@jleonqu jleonqu commented Jun 12, 2025

This is a draft PR to address issue #1377

Progress so far:

  1. Created the necessary files to run an Irregular CIC case for the OSWEC at: RegressionTests\IrregularWaves\irregularCIC_OSWEC
  2. Drafted test functions for the OSWEC in the regressionTests.m script

Next steps:

  1. Run the regressionTests.m script locally
  2. Verify the outputs for the OSWEC test functions
  3. Debug any issues in the last three functions, which correspond to the OSWEC case

@jleonqu jleonqu marked this pull request as draft June 12, 2025 20:41
@jleonqu jleonqu mentioned this pull request Jun 12, 2025
Closed
@MShabara MShabara requested a review from jtgrasb June 25, 2025 14:18
@jtgrasb
Copy link
Contributor

jtgrasb commented Jun 26, 2025

@jleonqu Thanks for opening up this PR. I made some updates to run the tests locally, verify the outputs, and debug. The tests are passing now here too. Is there anything else you were thinking about adding to this PR?

@kmruehl kmruehl self-assigned this Jun 27, 2025
@kmruehl kmruehl added the Tests/CI related WEC-Sim tests or Continuous Integration label Jun 27, 2025
@jtgrasb jtgrasb marked this pull request as ready for review July 9, 2025 14:20
@kmruehl kmruehl self-requested a review July 9, 2025 14:24
@kmruehl
Copy link
Collaborator

kmruehl commented Jul 11, 2025

Thank you @jleonqu and @jtgrasb. This looks good to me! I'm going to make a very minor revision to the plots, and then merge.

@kmruehl kmruehl merged commit af272a1 into WEC-Sim:dev Jul 11, 2025
10 checks passed
@kmruehl
Copy link
Collaborator

kmruehl commented Jul 11, 2025

Thank you @jleonqu and @jtgrasb. The OSWEC test is now merged into dev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmruehl kmruehl kmruehl approved these changes

@jtgrasb jtgrasb Awaiting requested review from jtgrasb

Assignees

@kmruehl kmruehl

Labels

Tests/CI related WEC-Sim tests or Continuous Integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jleonqu @jtgrasb @kmruehl