Modified sign convention when a cable pretension is defined #1478
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
If this is a bug it should go into |
Contributor
Author
|
Hi Kelley, I think it was a bug. You could see the comparison in the following plots. Happy to merge to main branch as recommended. BRs, |
Collaborator
|
Thanks @ttran18! @dforbush2 has offered to review this PR. In the meantime can you amend this PR to go into |
Contributor
|
I will merge this to dev, then create an identical PR into master. Thank you @ttran18 for catching this!! |
Merged
Collaborator
|
Thank you very much @ttran18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MShabara I did modify the cableClass.m to correct a cable pretension calculation. This modification is only for the cable tension input whereas the cable length input was good to calculate the cable tension output.