QTF Rotation #1477
Closed
QTF Rotation #1477
+68
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* match PR 1478 changes on main --------- Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov>
* Fixing Regression Tests for RM3 * Updating the correct _org.mat files * resolving figure issues --------- Co-authored-by: Ruehl <kmruehl@sandia.gov>
Collaborator
|
@jtgrasb can you please review this PR and it's associated application, WEC-Sim/WEC-Sim_Applications#86? thank you! |
Contributor
|
@MShabara The implementation makes sense, but I am getting some errors when I try to run it. I believe the body library hasn't been updated to account for the additional function input ( 
It also looks like there is a conflict in the library file. What I would recommend (assuming the only change to the body library needed is to add the Displacement as an input to that function) is to accept the body library from the dev branch, then add the displacement as an input in Simulink. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces modifications to both the body library and the
secondOrderExt.mfunction in order to account for body rotation when computing second-order wave excitation forces.This ensures that the second-order force components are accurately aligned with the body's orientation as it evolves in time, improving the physical fidelity of the force application, especially in simulations with large rotational motions.
This PR was requested by a user in Issue #1443