Bug fix for drag and nonhydro body block mass #1464
Merged
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
Will wait on this pending @jtgrasb's upcoming PR on allowing variable masses which will likely absorb this on dev |
Contributor
|
Upcoming PR is completely different. I checked this one with the nonhydro body Applications case and it worked as expected. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue (only in dev) from the library merge in #1411. It reverts the nonhydro and drag body blocks back to using
body.massinstead ofbody.hydroForce.hf1.mass. body.hydroforce is limited for those body types and doesn't contain all of the necessary information. Also variable hydro is not used for those bodies, so we may as well use body.mass directly