Dev: fix badBEMIOFix_fcn #1447
Dev: fix badBEMIOFix_fcn #1447
Conversation
|
@dforbush2 can we have this function also remove the peaks on dataset edges? I'm not familiar with it's internal working, but maybe it could truncate data to remove the edge peaks and then extrapolate the smoothed data back to the original frequency range? I'm using this update to fix some bad BEM data right now and am left with sharp peaks at the edges of my data. |
|
can do...the difficulty internally is that "peak" on the edge sometimes is just the "edge", but I can cook something up. |
|
@akeeste do you want to review this PR? |
|
converted to draft: @akeeste suggested fix is easy to implement and incoming soon |
|
@akeeste try that one. that will despike your endpoints |
|
Thanks @dforbush2 I'll test it out today. |
akeeste
left a comment
There was a problem hiding this comment.
Thanks @dforbush2 this update is working for me. Peaks on the edge no longer error
I can't post any plots of my tests since I'm using TEAMER data, but the function is working more robustly now.
|
That's great, thanks @dforbush2 and @akeeste |
this adds warnings if a peak is detected on the edge of the data set (which would otherwise error) and references the deSpike structure rather than hardcoded defaults.