-
Notifications
You must be signed in to change notification settings - Fork 184
Fix treatment of the inertia products in body.adjustMassMatrix #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Changing back to draft while I investigate the implementation of added mass adjustments with body interactions |
|
Ready for review again. I confirmed the implementation of our added mass adjustments in b2b cases and added to our documentation explaining it. |
|
@akeeste after reviewing the proposed documentation revisions, the |
|
Correcting my above comment: Those docs are now corrected and the inertia tensor is written correctly |
…justMassMatrix
|
@kmruehl FYI, see above comment for explanation. The docs build fine so this should be good to merge |
|
@akeeste thank you for the clarification and for reverting the revisions to the |
This PR fixes a minor bug in the treatment of the inertia products in
body.adjustMassMatrix(). See https://wec-sim.github.io/WEC-Sim/main/developer/advanced_features.html#theoretical-implementation for the documented reasoning which this update aims to match.