Add function to make sure BEM directions span 360 degrees for passive yaw and full directional spectra cases #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akeeste
requested changes
Feb 26, 2025
Contributor
akeeste
left a comment
There was a problem hiding this comment.
@jtgrasb
To make this compatible with simu.reloadH5Data=1, bodyClass.makeSpanNeg180To180 could update the hydroData direction instead of hydroForce direction, then that change is retained for subsequent MCR runs.
Given that makeSpanNeg180To180 now contains error messages related to full 360 directional coverage, I removed a duplicate message.
see jtgrasb#18
clean up and make compatible with not reloading hydrodata
Contributor
Author
|
@akeeste Thanks for the comments and changes! Changing the hydroData directions makes sense, and I merged your PR into this one and tested everything locally to confirm it is still working as expected. Ready to merge once the tests pass as I see it. |
akeeste
approved these changes
Feb 27, 2025
Contributor
|
@jtgrasb great! tests are passing. merging... |
This was referenced Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function that makes sure BEM directions span 360 degrees for passive yaw and full directional spectra cases. This prevents extrapolation from occurring.
As of now, if users are using a full directional spectrum with MCR, simu.reloadH5Data needs to be set to 1. This is because I am adding elements to the hydroData structure and it will try to add them again if it is not reloading H5. Open to suggestions on this if there is a better way.