Skip to content

add keepPool flag to simulationClass #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pm-gusmano wants to merge 2 commits into from
Closed

add keepPool flag to simulationClass #1412

pm-gusmano wants to merge 2 commits into from

Conversation

@pm-gusmano
Copy link
Contributor

@pm-gusmano pm-gusmano commented Feb 10, 2025

Allows users to run wecSimPCT using an existing parallel pool
Lets users decide whether to close the parallel pool after a successful run of wecSimPCT. By default, the parallel pool stays open, though this can easily be changed by setting simu.keepPool = 0.

Closes #1398

@dforbush2 dforbush2 self-assigned this Feb 13, 2025
@dforbush2 dforbush2 self-requested a review February 13, 2025 16:37
@dforbush2
Copy link
Contributor

dforbush2 commented Feb 13, 2025

Thanks @Gusmano-2-OSU
This looks good, and looks like it works as advertised. Is there a particular test case/directory you would recommend for its evaluation?

@dforbush2
Copy link
Contributor

dforbush2 commented Feb 13, 2025

Tested with Applications/Multiple_Condition_Runs/RM3_MCROPT1 via wecSimPCT. Works as advertised. I will add documentation to this PR and then merge.

@pm-gusmano
Copy link
Contributor Author

pm-gusmano commented Feb 13, 2025

Hey @dforbush2! I would test it with cases in the Multiple_Condition_Runs folder of the Wec-Sim_Applications repo!

@dforbush2
Copy link
Contributor

dforbush2 commented Feb 13, 2025

Hi @Gusmano-2-OSU

Can you please either:
advanced_features.txt

  1. give me push access to this fork, or
  2. replace ./docs/user/advanced_features.rst with the attached (please first re-save as .rst)

@pm-gusmano
Copy link
Contributor Author

pm-gusmano commented Feb 13, 2025

Hey @dforbush2! I added you as a collaborator, so you should be good to push to that repo.

@dforbush2
Copy link
Contributor

dforbush2 commented Feb 13, 2025

This PR is ready to go...but it appears our test suite is failing due to some other reasons. Will merge once resolved.
@Gusmano-2-OSU could you please create an additional PR that duplicates these features for a merge into WEC-Sim's dev branch? Please include the few modified lines of advanced_features.rst, too. We can get that one merged ASAP.

@pm-gusmano pm-gusmano mentioned this pull request Feb 13, 2025
Merged
@kmruehl kmruehl added MCR/PCT multiple condition runs (wecSimMCR) and/or parallel computing toolbox (wecSimPCT) Simulation Class Simulation Class (simulationClass.m) labels Feb 19, 2025
@kmruehl
Copy link
Collaborator

kmruehl commented Mar 10, 2025

@Gusmano-2-OSU thank you for this PR. We are going to close thie one, and work on merging #1418 into dev. Thanks!

@kmruehl kmruehl closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dforbush2 dforbush2 Awaiting requested review from dforbush2

Assignees

@dforbush2 dforbush2

Labels

MCR/PCT multiple condition runs (wecSimMCR) and/or parallel computing toolbox (wecSimPCT) Simulation Class Simulation Class (simulationClass.m)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Maintain Parallel Pool after wecSimPCT

3 participants

@pm-gusmano @dforbush2 @kmruehl