Bug fixes for applications #1401
Conversation
|
@kmruehl this is ready for review |
* Updates the Ubuntu and Matlab versions
|
@kmruehl any updates on the review for this PR? |
There was a problem hiding this comment.
@akeeste can you explain the differences made to the Body Library?
There was a problem hiding this comment.
@akeeste correct me but I think I have it:
The only difference is here, in the mask initialization functions of "Hydrodynamic Body/Wave Diffraction and Excitation Force Calculation"
Note the purple highlight is an insignificant whitespace difference. To my eye, this is a fine, but unnecessary, change and is OK to merge. These are the line routings in question:
I suspect this particular addition may be in preparation of the forthcoming change to excitation calculations with multiple sets of hydrodynamic data suggested in, #1394 , at which time explicitly specifying this routing will be more robust.
The only reason I suspect it works as-is is that the default behavior of the blocks will carry them in all cases where there is a single set of hydrobody data (i.e., the only extant subfield is hf1).
Short answer: this is an intentional and good change to the body library block that I suggest is merged.
|
I'm going to amend the test cases to revert to the last four versions of MATLAB and then merge the PR |
|
@dforbush2 @kmruehl yes that change to the body library mask was in a previous bugfix and must have gotten dropped at some point during all the library changes in the latest release. The mask line is necessary for the multiple wave definitions to work with the variable hydro changes |
PR to address the bugs appearing in our applications cases, as described in #1400. Closes #1400