MoorDyn variable path support #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgrasb
reviewed
Dec 5, 2024
Contributor
|
@RyanDavies19 I left one minor comment. Other than that, I tested it out and this looks great and will be ready for merge! |
508d51e to
d2bf6e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some MoorDyn path things to support V2 (input files can have any name or path). Previously there were instances of MoorDyn v1 file naming that was hard coded. Now, the input file name and path is used to derive the output file names and paths. This requires the MoorDyn filename in the wecSimInputFile to only have a single "." character, I added tests accordingly that check this and that the file exists.
If there are formatting things that need changing here please let me know! I tried to follow how other parts of the code do things as closely as possible.