Multiple wave instances bug fix #1371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@MShabara We can remove the From blocks to fix this issue for multiple waves, but they need to be replaced with lines that manually route from the output of |
Contributor
Author
Contributor
|
Closing in favor of #1373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple wave instances are defined by the user, the body library duplicates the hydrodynamic calculations and combines their outputs. However, in the current version, the "From" blocks remain linked exclusively to Body(1) and are not updated dynamically for additional bodies.
To address this, changes were reverted to align the body library behavior with version 6.0. The key modifications include:
1- Updates to the initialization functions of the following blocks:
"Rigid Body"
"Hydrodynamic Body"
2- Adjustments to the following wave excitation force blocks:
"Regular Wave Excitation Force"
"Nonlinear Yaw Excitation Force"
"Irregular Wave Excitation Force"
"Irregular Wave Nonlinear Yaw"