Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Oct 16, 2024

This PR resolves #1305. No other BEMIO functions gave this indexing error except readWAMIT.

@akeeste akeeste linked an issue Oct 16, 2024 that may be closed by this pull request
@kmruehl kmruehl self-requested a review October 16, 2024 15:07
@kmruehl kmruehl self-assigned this Oct 16, 2024
@kmruehl kmruehl added BEM/BEMIO related to BEMIO or BEM hydro data WAMIT labels Oct 16, 2024
@akeeste
Copy link
Contributor Author

akeeste commented Oct 16, 2024

Documentation tests breaking for other reasons. I'll add a PR for that

@akeeste
Copy link
Contributor Author

akeeste commented Oct 16, 2024

The documentation build test will pass once #1342 is merged into main and then pulled into dev. All other tests are passing.

@kmruehl
Copy link
Collaborator

kmruehl commented Oct 16, 2024

Thanks @akeeste I'll merge now

@kmruehl kmruehl merged commit 37b0edd into WEC-Sim:dev Oct 17, 2024
@akeeste akeeste deleted the bemioWarning branch October 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BEM/BEMIO related to BEMIO or BEM hydro data WAMIT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Developer Issue] BEMIO warning soon to be an error

2 participants