Speed up writeBEMIOH5 #1301
Merged
Speed up writeBEMIOH5 #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Collaborator
|
Thanks @akeeste, this is a great suggestion. I certainly see value in having the component information in the h5 files for easy viewing/plotting of this data. However, that benefit is minimal when compared to the computation expense and size of the resulting h5 file. Plus, as you mentioned, the data is already contained within the h5, it just requires a bit more (or different) post-processing to plot each component. In short, I'm going to go ahead and merge this PR. If we decide we don't like it, we can revert. |
kmruehl
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writeBEMIOH5can take a very long time. Almost all of the BEM coefficients are written twice, in the "components" groups, but never used in WEC-Sim. These groups are never read in byreadBEMIOH5In my testing with the directional OSWEC data in the Applications repo, this duplicate data takes approximately 98.9% of the CPU time of
writeBEMIOH5and increases the H5 file size by almost 4 times.This PR eliminates the duplicate writing of BEM data into the "component" groups and significantly reduces the computational expense of
writeBEMIOH5. This will critically enable the use of variable hydro.