Expand regression tests #1273
Expand regression tests #1273
Conversation
| bemio | ||
| cd(testCase.testDir); | ||
| end | ||
|
|
There was a problem hiding this comment.
I wonder if this test is better suited for bemioTest.m, instead of the RM3 regression test. If there is an issue with BEMIO, it seems like we should test it in bemioTest.m. That also allows us to compare across BEM solvers, and to a prior solution.
Right now, we run the sphere cases in all BEM solvers, but it doesn't look like we compare the solutions. The sphere was chosen because it's a simple/fast case, but we could run the RM3 and compare the results to the uploaded h5, in the RM3 example.
@akeeste what do you think about this suggestion?
|
Thanks @akeeste. Let's go ahead and merge this PR to resolve the immediate issue. BEMIO is not currently run for the regression tests, so if there are any updates to |
This PR expands the regression tests to account for accuracy bugs in BEMIO functions.
Currently the regression tests run the RM3 model using the committed hydroData in
examples/RM3/hydroData/rm3.h5.If a BEMIO function is updated and runs functionally, but is inaccurate, the regression test will still pass because BEMIO is not being re-run. e.g. the tests here should have failed because the body cg, cb and volume were written incorrectly. The regression tests passed however because BEMIO is not rerun.
This update will not catch inaccuracies in:
but it will catch issues in readWAMIT, radiationIRF, radiationIRFSS, excitationIRF, and writeBEMIOH5