Add missing mask initialization line in spherical constraint #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@MShabara Once these tests finish passing, I will merge this PR so that the Applications tests re-run and we can confirm that the Cable Application is working again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1198 added PTO/Constraint extension. I missed a line in the new mask initialization when I extended the PTO extension feature to the spherical constraint, causing the Cable Application to fail on dev. This PR fixes that line and the Cable example runs locally now.
#1198 is only in dev, so this bugfix is going straight into dev.
I double checked the other relevant constraint/PTO blocks and they should have the right mask commands already.