Skip to content

Conversation

@jleonqu
Copy link
Contributor

@jleonqu jleonqu commented Mar 4, 2024

This PR is based on PR #1221. This new PR is rebase on the 'main' branch of WEC-Sim

@H0R5E
Copy link
Contributor

H0R5E commented Mar 15, 2024

@jleonqu, you'll need to push an update to trigger the CI. It should work now.

@dforbush2
Copy link
Contributor

I have reviewed and tested on 2022b and 2023b windows, tested using applications case PR #58. This is ready to merge.
However, I would suggest that we consider the documentation's level of detail and/or advise users to look closely at the implementation of these PTO blocks prior to use. For instance, motor back EMF constant is implemented as equal to motor torque constant: this is true only under very specific conventions that may not align with device developer specs.

@kmruehl kmruehl added the Bug bug in WEC-Sim source, high priority label Mar 20, 2024
@kmruehl kmruehl requested a review from dforbush2 March 20, 2024 14:45
@kmruehl kmruehl added the PTO-Sim PTO-Sim (ptoSimClass.m) label Mar 20, 2024
@dforbush2 dforbush2 merged commit 453af81 into WEC-Sim:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug bug in WEC-Sim source, high priority PTO-Sim PTO-Sim (ptoSimClass.m)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants