Add new examples for updated version of NEMOH (NEMOHv3.0.2) #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It takes a long time to run >200 freqs for 7 cases. I propose a test option, where we just run ~20 freqs for each case and check the results? I can work on this - just want to check if this approach makes sense to others first. |
It takes a really long time to run the default number of frequencies for each of these cases. This run_nemoh.py script enables the user to specify the number of frequencies and the version of Nemoh (main(num_freqs=6, version='v2.3')). This makes it much faster to run a select number of frequencies for comparing the results between different Nemoh versions.
Contributor
|
I just pushed a script to more easily edit the number of frequencies and run Nemoh (either v2 or v3) and a plotting script to compare results - please can you test these out for yourself and check that they are ok? I did see some differences in the results of each code but I suppose that is to be expected... Some of the v2 examples had a range of wave headings - I noticed the updated v3 examples lost this and only have one heading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated example files for NEMOHv3.0.2