Skip to content

Conversation

@jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Dec 5, 2023

This PR updates wecSim.m to reference the new MoorDyn library (libmoordyn) instead of the old one (Lines). This is an update that should have been included in the previous MoorDyn updates but was left out by mistake. Discovered in Issue #1171

This is a bug and should be pushed to both Master and Dev.

@jtgrasb jtgrasb added Bug bug in WEC-Sim source, high priority MoorDyn MoorDyn implementation in WEC-Sim labels Dec 5, 2023
@hfchen20
Copy link

hfchen20 commented Dec 5, 2023

@jtgrasb Same thing in postProcessWecSim.m.
https://github.com/WEC-Sim/WEC-Sim/blob/master/source/functions/postProcessWecSim.m#L131-L134

FYI. I'm able to run MoorDyn related cases, even with these Lines statements present.

@akeeste akeeste self-requested a review December 13, 2023 15:26
@akeeste akeeste self-assigned this Dec 13, 2023
Copy link
Contributor

@akeeste akeeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtgrasb . I reviewed and ran things locally. Tests are passing. Can you pull master into dev after this is merged?

@akeeste akeeste merged commit 3d4bc12 into WEC-Sim:master Dec 13, 2023
@jtgrasb
Copy link
Contributor Author

jtgrasb commented Dec 13, 2023

Thanks for merging. Yes, I can do that. One note: PR #1176 is also in Master but not dev. I assume we want to also pull this into dev, correct?

@akeeste
Copy link
Contributor

akeeste commented Dec 13, 2023

@jtgrasb yes, #1176 and any other updates to master since the release should merge into dev too. Same goes for the branches on the Applications repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug bug in WEC-Sim source, high priority MoorDyn MoorDyn implementation in WEC-Sim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants