-
Notifications
You must be signed in to change notification settings - Fork 184
Control+pto docs #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control+pto docs #1108
Conversation
docs/user/advanced_features.rst
Outdated
| :width: 500pt | ||
| :align: center | ||
| The PTO parameters used for this example are defined in the wecSimInputFile and correspond to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial comment: can we use wecSimInputFile.m instead of the current labeling to assist in defining there is a separate file that can be referenced. Also not possible now, but can we add a citation, link, or point to the soon to be included applications case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First part resolved. Leaving open to add link to point to applications case when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial Comment: Request that rather than time averaged power, can we plot as capture width. Understand the point here is to see the relative difference between the green and red bars, but myself forgetting the size of the sphere and the wave conditions you have used makes the power numbers difficult to relate too. I think plotting against available wave power would also highlight how much power is needed to drive the motor relative to what is available in the waves. Also add sea state conditions for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed plots to capture width instead of power. I am not sure if it is better or not, but I do think it is good to see the results relative to wave power. The one thing that may be confusing is that all the other controllers documentation refers to the average power, so it may be confusing to change to capture width for only this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies as I should have been also reviewing the other controller documentation for consistency. Then perhaps can we include both dimensional power plots and capture width for this example? The capture width plot I think is really helpful as in the unoptimized case the electrical input is 35 times the power hitting the sphere. So my request would be to have just two figures, dimensional to be consistent with other controller examples and the capture width to relate to wave climate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I agree that having both figures provides more understanding and context, so added back the power plots. Thanks!
|
@jtgrasb Thanks for addressing my comments and requests. I'm good with this pull request, but will wait to see how you wanted to address the power figure question, power vs capture width. Once you have a decision and let me know I'll merge this PR along with the WEC-Sim Applications PR. |
|
@jtgrasb Thanks for confirming there were no other updates to the PR. I've merged into Dev. |
Documentation to go with new controls + PTO applications case (WEC-Sim/WEC-Sim_Applications#40)