Skip to content

Conversation

@jtgrasb
Copy link
Contributor

@jtgrasb jtgrasb commented Aug 22, 2023

Documentation to go with new controls + PTO applications case (WEC-Sim/WEC-Sim_Applications#40)

@kmruehl kmruehl added Control control related PTO-Sim PTO-Sim (ptoSimClass.m) labels Sep 6, 2023
@kmruehl kmruehl requested a review from nathanmtom September 6, 2023 14:44
:width: 500pt
:align: center
The PTO parameters used for this example are defined in the wecSimInputFile and correspond to

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comment: can we use wecSimInputFile.m instead of the current labeling to assist in defining there is a separate file that can be referenced. Also not possible now, but can we add a citation, link, or point to the soon to be included applications case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part resolved. Leaving open to add link to point to applications case when possible.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link

@nathanmtom nathanmtom Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial Comment: Request that rather than time averaged power, can we plot as capture width. Understand the point here is to see the relative difference between the green and red bars, but myself forgetting the size of the sphere and the wave conditions you have used makes the power numbers difficult to relate too. I think plotting against available wave power would also highlight how much power is needed to drive the motor relative to what is available in the waves. Also add sea state conditions for clarity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed plots to capture width instead of power. I am not sure if it is better or not, but I do think it is good to see the results relative to wave power. The one thing that may be confusing is that all the other controllers documentation refers to the average power, so it may be confusing to change to capture width for only this example.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies as I should have been also reviewing the other controller documentation for consistency. Then perhaps can we include both dimensional power plots and capture width for this example? The capture width plot I think is really helpful as in the unoptimized case the electrical input is 35 times the power hitting the sphere. So my request would be to have just two figures, dimensional to be consistent with other controller examples and the capture width to relate to wave climate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I agree that having both figures provides more understanding and context, so added back the power plots. Thanks!

@nathanmtom
Copy link

@jtgrasb Thanks for addressing my comments and requests. I'm good with this pull request, but will wait to see how you wanted to address the power figure question, power vs capture width. Once you have a decision and let me know I'll merge this PR along with the WEC-Sim Applications PR.

@nathanmtom nathanmtom merged commit 930f58d into WEC-Sim:dev Sep 20, 2023
@nathanmtom
Copy link

@jtgrasb Thanks for confirming there were no other updates to the PR. I've merged into Dev.

@jtgrasb jtgrasb deleted the control+pto_docs branch October 18, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Control control related PTO-Sim PTO-Sim (ptoSimClass.m)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants