readNEMOH update to be compatible with v3.0.0 release (but not QTF) #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@nathanmtom should this go into master or dev? |
kmruehl
approved these changes
Aug 11, 2023
Collaborator
kmruehl
left a comment
There was a problem hiding this comment.
Thanks @nathanmtom! I tested this on NEMOH v3.0, and with the current BEMIO examples. It's ready for a merge. Also, thanks for adding updating the BEMIO examples to NEMOH v3.0 to the project board.
Collaborator
|
Oops! @nathanmtom should this go in dev or master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to reflect changes to the NEMOH input and output files that necessitate an update to readNEMOH.
Changes are:
The files were updated to be compatible with v3.0.0 release and existing NEMOH files in the WEC-Sim Examples BEMIO folder.
Note: As it appears NEMOH is providing updates the WEC-Sim team may decide in the future to make readNEMOH only compatible with the latest NEMOH release.
Note: The Examples BEMIO folder need to be updated as changes to the NEMOH.cal and input.txt were made such that the existing input files are incompatible. Placing a project board ticket to update.