Skip to content

adding bemio cleanup function #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akeeste merged 7 commits into from
Nov 21, 2023
Merged

adding bemio cleanup function #1076

akeeste merged 7 commits into from
Nov 21, 2023

Conversation

@dforbush2
Copy link
Contributor

@dforbush2 dforbush2 commented Jun 28, 2023

Not ready for merge, but eventually we want it and devs may find it useful in the interim.

@kmruehl kmruehl added Feature new feature request BEM/BEMIO related to BEMIO or BEM hydro data labels Jul 12, 2023
@kmruehl kmruehl marked this pull request as draft July 12, 2023 14:57
@kmruehl kmruehl requested a review from akeeste July 12, 2023 14:58
@akeeste
Copy link
Contributor

akeeste commented Aug 9, 2023 •
edited
Loading

@dforbush2 I tested this functionality on several noisy BEM cases today and it works wonderfully. Both excitation and radiation IRFs are much cleaner and more realistic. I don't have the expertise to mess with the deSpike settings that go into findpeaks or filtfilt, but it works great with the defaults. I can't post screenshots of my tests because they're proprietary, but can share another time.

Line 318 needs to be hydro.plotDofs = plotDofs to use it as is for cases without GBM modes. I left other refactoring alone until we decide what to do with this functionality.

@dforbush2 dforbush2 mentioned this pull request Aug 30, 2023
Closed
@salhus salhus mentioned this pull request Sep 6, 2023
Closed
@dforbush2
Copy link
Contributor Author

dforbush2 commented Oct 18, 2023

Added a fix to readWAMIT to handle both GBM and FSP additional modes.

@dforbush2 dforbush2 marked this pull request as ready for review October 18, 2023 18:20
@akeeste akeeste mentioned this pull request Nov 8, 2023
Merged
4 tasks
@nathanmtom nathanmtom added the Cable Class Cable Class (cableClass.m) label Nov 15, 2023
@akeeste
Copy link
Contributor

akeeste commented Nov 21, 2023

I pushed the removal of extra files and indexing update directly to your branch @dforbush2. Merging now

@akeeste akeeste merged commit 334f8cf into WEC-Sim:dev Nov 21, 2023
@akeeste akeeste self-assigned this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akeeste akeeste Awaiting requested review from akeeste

Assignees

@akeeste akeeste

Labels

BEM/BEMIO related to BEMIO or BEM hydro data Cable Class Cable Class (cableClass.m) Feature new feature request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dforbush2 @akeeste @kmruehl @nathanmtom