Update writeBEMIOH5.m #1063
Update writeBEMIOH5.m #1063
Conversation
The commit addresses issue #1028 in a better way. Although, BEMIO was reading the AQWA data correctly, the writeBEMIOH5 did not do the necessary transpose.
|
@salhus This PR does not appear to rollback the other PR merged to resolve the question on the hydrostatic stiffness matrix. Does this PR mean it still needs those changes or are you planning to rollback that PR then merge here? |
|
@salhus It does appear that the readBEMIOH5.m file in this branch does not have the extra line to zero out the final yaw row, but in WEC-Sim 'Dev' that line can be found. Given this is a small change I am requesting if you can close this issue, and submit a new PR after setting up a branch with an updated 'Dev' branch. Also, have you checked to see if this impacts the hydrostatic matrix for NEMOH, Capytaine, and WAMIT? When I reviewed the hydrostatic matrix for the AQWA and NEMOH, we appear to be importing the 6x6 matrix where as for WAMIT it is only the upper right diagonal. Therefore, we shouldn't need any transpose for AQWA and NEMOH and a fix should then occur only in the readWAMIT.m to correct for the different importation of the hydrostatic stiffness matrix. |
|
@nathanmtom, re: Hydrostatics matrix transpose, I describe this more clearly in the new PR. |
The commit addresses issue #1028 in a better way.
Although, BEMIO was reading the AQWA data correctly, the writeBEMIOH5 did not do the necessary transpose.
BEMIO was reading the AQWA data correctly, but the writeBEMIOH5.m function was not doing the necessary transpose.
For reference, here is a check that readAQWA function was working correctly.
However, when I looked at the h5 file in an h5 file viewer, the writeBEMIOH5 function should have taken a transpose.
Following the fix I made, here is how the hydrostatics matrix looks, confirming that the writeBEMIOH5 and readBEMIOH5 are working as intended.
and here is the h5 file viewer,