Skip to content

Add windows runner to dev branch unit test workflow #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmruehl merged 1 commit into from
May 22, 2023
Merged

Add windows runner to dev branch unit test workflow #1061

kmruehl merged 1 commit into from
May 22, 2023

Conversation

@H0R5E
Copy link
Contributor

@H0R5E H0R5E commented May 22, 2023 •
edited
Loading

This PR changes the following:

  • Added a Windows runner to the dev branch unit tests workflow by using the beta version of setup-matlab
  • Added untested versions of MATLAB (R2022a, R2022b)
  • Allows the workflow to be triggered manually

@H0R5E
Copy link
Contributor Author

H0R5E commented May 22, 2023 •
edited
Loading

I can create a clone PR for the master branch tests, but I wondered if we'd like to try this out in dev for a while first before doing that?

EDIT: Something to note is that the tests now required 2x to 3x the amount of time to complete. This is because MATLAB is slower to install using the beta version of setup-matlab.

@H0R5E H0R5E changed the title Add windows runner to unit test workflow Add windows runner to dev branch unit test workflow May 22, 2023
@H0R5E
Add windows runner to unit test workflow
2834039 
This commit changes the following:

+ Added a windows runner to the unit tests workflow by using the beta
  version of setup-matlab
+ Added untested versions of MATLAB (R2022a, R2022b)
+ Allows the workflow to ve triggered manually
@H0R5E H0R5E force-pushed the github_actions_windows branch from 559a0c7 to 2834039 Compare May 22, 2023 10:41
@kmruehl kmruehl self-requested a review May 22, 2023 23:54
@kmruehl kmruehl added the Tests/CI related WEC-Sim tests or Continuous Integration label May 22, 2023
@kmruehl
Copy link
Collaborator

kmruehl commented May 22, 2023

@H0R5E this is great, thank you! I agree with your assessment to keep this on dev for now. We have a milestone for a new release by the end of the FY, so it'll be on master soon enough.

Also, thanks for the FYI on the runtime. We may want to revisit how many versions of MATLAB we want to support (and test). Thanks again!

@kmruehl kmruehl merged commit 4a874b2 into WEC-Sim:dev May 22, 2023
@H0R5E H0R5E deleted the github_actions_windows branch May 23, 2023 08:19
@H0R5E
Copy link
Contributor Author

H0R5E commented May 23, 2023

We have a milestone for a new release by the end of the FY, so it'll be on master soon enough.

@kmruehl, just to clarify this point, the actual master workflow (.github/workflows/run-tests-master.yml) still needs to be updated to use the windows runners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmruehl kmruehl Awaiting requested review from kmruehl

Assignees

No one assigned

Labels

Tests/CI related WEC-Sim tests or Continuous Integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@H0R5E @kmruehl