Skip to content

Added mass updates #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
salhus merged 8 commits into from
Jul 26, 2023
Merged

Added mass updates #1058

salhus merged 8 commits into from
Jul 26, 2023

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented May 17, 2023 •
edited
Loading

PR to address project card

TODO

  • save added mass force time series (Fix the transpose of linear restoring matrix to make roll mode rows to be 0 #1032)
  • change post-processing to save the actual added mass time series
  • add to developer manual on how users can manipulate the added mass force during the simulation
  • update adjMassFactor to be body-dependent
  • fix how the products of inertia are adjusted in the bodyClass
  • confirm that documentation updates build correctly

@akeeste akeeste added Documentation related to docs Added Mass related to added mass labels May 17, 2023
@akeeste akeeste marked this pull request as ready for review May 18, 2023 20:26
@kmruehl kmruehl requested a review from salhus May 31, 2023 14:36
@akeeste
Copy link
Contributor Author

akeeste commented May 31, 2023

@salhus I got the documentation building this morning and was able to fix my typos, equations, etc. This PR is ready for review.

Adam

@salhus salhus merged commit cba3cca into WEC-Sim:dev Jul 26, 2023
@akeeste akeeste deleted the added_mass_updates branch August 2, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salhus salhus Awaiting requested review from salhus

Assignees

@salhus salhus

Labels

Added Mass related to added mass Documentation related to docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akeeste @salhus