Add function to read h5 file to hydro data structure #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanmtom
approved these changes
May 5, 2023
nathanmtom
left a comment
There was a problem hiding this comment.
@jtgrasb Thanks for building this function to allow a user to quickly check their hydrodynamic coefficients without re-running the full BEMIO script. I approve this PR.
One note, is that when looking at the plots for the comparison you added in compareBEMIO.m, it is hard to tell there are four lines because the line style is solid. I am not requesting this as part of this PR, but potentially a nice change would be to update the linestyles for each new line in the formatPlot.m.
|
Thanks for creating this function and updating the writeBEMIOh5.m to reflect other values that should be stored in the .h5. I'll merge this shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to BEMIO to allow the h5 file to be read in as a hydro structure. This allows the hydro data in an h5 file to be plotted even without access to the BEM files that it was read from. A couple lines were added to writeBEMIO to make sure all the hydro data was written to the h5 file, and this lead to small additions to rm3.h5 and oswec.h5. This also adds an example to compareBEMIO.m to show how the h5file can be read into a hydro data structure.