Update read- and writeBEMIOH5 to allow for pressure integration for mean drift #1046
Conversation
|
Hi @nathanmtom I tested this PR with the mean drift applications case and got an error because the bodyClass has a check to make sure meanDrift is between 0:2. This needs to be changed to 0:3. Other than that, this PR seems to work well! |
|
Thanks for the quick review @jtgrasb, did not catch that as I didn't actually try to run WEC-Sim so missed the bodyClass checkInput warning. I believe this only occurs here and couldn't break the code by changing other parameters, but let me know if this check needs to be implemented in another place. Checking the meanDrift application case also shows that I'll need to update that case as it does not seem to reflect the v5.0 refactoring and will need to update to demonstrate the 'pressure integration' option. I'll put this as a project board tag and get to it in the near future. |
|
Looks great @nathanmtom. Merging now! As for the applications case, I noticed this as well yesterday and made a PR updating the userDefinedFunctions. Let me know if there was anything else you saw that should be updated. |
This is an update to the read- and writeBEMIOH5 to allow for pressure integration for the mean drift force import.
This update should address issue #1020 as the import of the pressure integration is successful when reading the input file, but is not written to the .h5 file (writeBEMIOH5) and when reading the h5 file there is no option for specifying the pressure integration option.