Update radiationIRF.m #1045
Merged
Update radiationIRF.m #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small fix to ensure that the infinite frequency added mass is calculated using the same range of frequencies used to calculate the impulse response function. Working with a user, we realized that the infinite frequency added mass calculation was flawed if there were low or high range of frequencies where the hydrodynamic coefficients were suspect. This arose in a Capytaine run where low frequency behavior impacted the calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix to ensure that the infinite frequency added mass is calculated using the same range of frequencies used to calculate the impulse response function. Working with a user, we realized that the infinite frequency added mass calculation was flawed if there were low or high range of frequencies where the hydrodynamic coefficients were suspect. This arose in a Capytaine run where low frequency behavior impacted the calculation.
I would like to give credit to @ccz359 for helping identify the bug which led to this fix.