Skip to content

Save mooring library to R2020b #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtgrasb merged 1 commit into from
Apr 21, 2023
Merged

Save mooring library to R2020b #1040

jtgrasb merged 1 commit into from
Apr 21, 2023

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Apr 21, 2023 •
edited
Loading

This PR resolves issues #1037 #1038

I will pull this change from master into dev after merging.

@akeeste akeeste self-assigned this Apr 21, 2023
@akeeste akeeste requested a review from jtgrasb April 21, 2023 20:23
@akeeste akeeste mentioned this pull request Apr 21, 2023
Closed
@jtgrasb
Copy link
Contributor

jtgrasb commented Apr 21, 2023

Thanks Adam, I am confirming that this successfully resolves Issues #1037 and #1038. I will merge it once the tests pass.

Per our discussion, I looked at the existing test suite and there does not seem to be any tests to check the version of MATLAB used in our library files.

@jtgrasb jtgrasb merged commit 430ffff into WEC-Sim:master Apr 21, 2023
@jtgrasb
Copy link
Contributor

jtgrasb commented Apr 24, 2023

Hi @akeeste,
I was looking back at old PRs to find our version saving practice and found where the version tests are added (PR #919). These changes are still only in dev while the mooring library issue was in master, so that is why it was not detected by any tests.

@akeeste
Copy link
Contributor Author

akeeste commented Apr 24, 2023

@jtgrasb Thanks for the note! Glad that test will move into master eventually

@akeeste akeeste deleted the bug_mooringLibVersion branch May 17, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtgrasb jtgrasb Awaiting requested review from jtgrasb

Assignees

@akeeste akeeste

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akeeste @jtgrasb