Skip to content

Original shutdown_default_executor() from uvloop.#25

Merged
Vizonex merged 1 commit intomainfrom
shutdown-default-executor
May 17, 2024
Merged

Original shutdown_default_executor() from uvloop.#25
Vizonex merged 1 commit intomainfrom
shutdown-default-executor

Conversation

@lschoe
Copy link
Collaborator

@lschoe lschoe commented May 17, 2024

Original code seems fine, and also has keyword argument timeout, which functions as the dummy used to resolve #21.

Original code seems fine, and also has keyword argument timeout, which functions as the dummy used to resolve #21.
@lschoe
Copy link
Collaborator Author

lschoe commented May 17, 2024

Maybe function shutdown_default_executor() was changed for certain reasons in the past. But I don't see a reason now why the original code from uvloop cannot simply be used. The original function has the optional timeout parameter (hence the dummy is not needed).

@Vizonex Do you think so as well?

@Vizonex
Copy link
Owner

Vizonex commented May 17, 2024

@lschoe just had a look at the code let me merge your changes

@Vizonex Vizonex merged commit db2f490 into main May 17, 2024
@lschoe
Copy link
Collaborator Author

lschoe commented May 17, 2024

Thx @Vizonex! This helps to zoom in on the essential code parts that you have developed to realize uvloop on Windows. The cause for #18 is still open, but there is no real hurry with that one.

Would be nice to bring winloop\loop.pyx and uvloop/loop.pyx closer together, aiming for an ultimate merge.

@lschoe
Copy link
Collaborator Author

lschoe commented May 17, 2024

Forgot to say this. With the winloop source more closely following the uvloop source, it will also be easier for a uvloop developer to decide if/how winloop can be merged with uvloop. Hopefully;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python3.12 fail to close asyncio.Runner

2 participants