Original shutdown_default_executor() from uvloop.#25
Merged
Conversation
Original code seems fine, and also has keyword argument timeout, which functions as the dummy used to resolve #21.
Collaborator
Author
|
Maybe function shutdown_default_executor() was changed for certain reasons in the past. But I don't see a reason now why the original code from uvloop cannot simply be used. The original function has the optional @Vizonex Do you think so as well? |
Owner
|
@lschoe just had a look at the code let me merge your changes |
Collaborator
Author
Collaborator
Author
|
Forgot to say this. With the winloop source more closely following the uvloop source, it will also be easier for a uvloop developer to decide if/how winloop can be merged with uvloop. Hopefully;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original code seems fine, and also has keyword argument timeout, which functions as the dummy used to resolve #21.