Skip to content

Put all (socket)errors in form UV_ERROR.#24

Merged
Vizonex merged 4 commits intomainfrom
UV-errors
May 17, 2024
Merged

Put all (socket)errors in form UV_ERROR.#24
Vizonex merged 4 commits intomainfrom
UV-errors

Conversation

@lschoe
Copy link
Collaborator

@lschoe lschoe commented May 16, 2024

Use same names for errors as in uvloop\includes\uv.pxd.

Use same names for errors as in uvloop\includes\uv.pxd.
@lschoe
Copy link
Collaborator Author

lschoe commented May 16, 2024

Hi @Vizonex!
The past couple of days I've made (hopefully) nonbreaking changes throughout the code. It would be nice if you can double check this for the latest version, to see if there are also no problems on your side.

So, the goal with all these changes is to avoid any nonessential differences with uvloop (version 0.19). And also a goal is to resolve issue #18 eventually.

For the upcoming changes I want to be a bit more careful, by first creating a PR for you to check. That way we can go step by step.

This first PR is about renaming the errors related to errno.h and socket errors to names of the form UV_, as done in uvloop\includes\uv.pxd. I don't see problems when running this new code, but that doesn't say much as it's hard to cause these errors to happen.

What do you think about this PR?

@lschoe
Copy link
Collaborator Author

lschoe commented May 17, 2024

PS. Make sure to use a squash merge to keep the commits history clean.

@Vizonex Vizonex merged commit d64c896 into main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants