Skip to content

chore: update actions, minor fixes#87

Merged
mgmacias95 merged 3 commits intoVirusTotal:masterfrom
kbdharun:master
Jan 2, 2024
Merged

chore: update actions, minor fixes#87
mgmacias95 merged 3 commits intoVirusTotal:masterfrom
kbdharun:master

Conversation

@kbdharun
Copy link
Copy Markdown
Contributor

@kbdharun kbdharun commented Dec 7, 2023

Changes

  • Bump actions/checkout from v3 (Node 16) to v4 (Node 20).
  • Bump actions/setup-go from v4 to v5 (Node 20) [This release also comes with some improvements to caching between builds].
  • Set default end of line (eol) to LF (this would prevent conversion to CRLF when making PRs from Windows) in the new .gitattributes file.
  • Fix spacing between codeblocks and other elements (It is generally good practice to have a line of space between the contents and the codeblock itself).

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
README.md Outdated
Comment on lines +111 to +121
Make sure the `bash-completion` package is installed (Cygwin doesn't installed it by default) and type:
```sh
$ vt completion bash > /usr/share/bash-completion/completions/vt
```
Make sure the `bash-completion` package is installed (Cygwin doesn't installed it by default) and type:

```sh
$ vt completion bash > /usr/share/bash-completion/completions/vt
```
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks the formatting of our readme. Revert it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, fixed it. Made some minor modifications too, feel free to let me know if I need to revert anything.

Copy link
Copy Markdown
Member

@mgmacias95 mgmacias95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@mgmacias95 mgmacias95 merged commit 3712a1b into VirusTotal:master Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants