[Fix] Virtual path lookup fixed#87
Merged
joelhawksley merged 1 commit intoViewComponent:masterfrom Oct 29, 2019
juanmanuelramallo:fix-virtual-path-method
Merged
[Fix] Virtual path lookup fixed#87joelhawksley merged 1 commit intoViewComponent:masterfrom juanmanuelramallo:fix-virtual-path-method
joelhawksley merged 1 commit intoViewComponent:masterfrom
juanmanuelramallo:fix-virtual-path-method
Conversation
Contributor
juanmanuelramallo
commented
Oct 26, 2019
- Solves Component with translations #74 (comment)
- Whenever the file path contained the pattern /.rb/ the component did not work properly with translations shortcuts
- Updated the method to escape the dot in the regular expression
- Whenever the file path contained the pattern /.rb/ the component did not work properly with translations shortcuts - Updated the method to escape the dot in the regular expression
Member
|
👏 thanks for the clean PR ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.