Add Base.sidecar_files to fetch sidecar paths#676
Merged
joelhawksley merged 1 commit intomainfrom Mar 24, 2021
Merged
Conversation
This is used by the sidecar translations but can actually be useful for supporting other types of sidecar assets. Also the original method in the compiler was only referencing the component class, which is a good hint this method should rather live there.
bae304c to
dc223ec
Compare
Merged
joelhawksley
approved these changes
Mar 24, 2021
Member
|
🙇🏻 ❤️ thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This has been extracted from #660 but can actually be useful for supporting other types of sidecar assets.
Other Information
The original method in the compiler was only referencing the component class, which is a good hint this method should rather live there.