Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: min_coverage parsing with default to 100#290

Merged
alestiago merged 9 commits into
VeryGoodOpenSource:mainfrom
kelvinwieth:fix/min-coverage-parsing
Oct 31, 2023
Merged

fix: min_coverage parsing with default to 100#290
alestiago merged 9 commits into
VeryGoodOpenSource:mainfrom
kelvinwieth:fix/min-coverage-parsing

Conversation

@kelvinwieth

@kelvinwieth kelvinwieth commented Oct 14, 2023

Copy link
Copy Markdown
Contributor

Description

Following the conversation on #287, this PR:

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@kelvinwieth

Copy link
Copy Markdown
Contributor Author

This may be a breaking change. The current behavior is min_coverage with defaults to 0, and fixing it to 100 would "cause existing functionality to change".

Comment thread index.js
Comment thread index.test.js
Comment thread index.js
Comment thread index.js Outdated
alestiago
alestiago previously approved these changes Oct 19, 2023

@alestiago alestiago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for working on this! 💙

Comment thread index.js Outdated
@kelvinwieth

kelvinwieth commented Oct 19, 2023

Copy link
Copy Markdown
Contributor Author

@alestiago with the addition of min_coverage between 0 and 100, now I think this is definetly a breaking change. What do you think?

@alestiago

alestiago commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

@alestiago with the addition of min_coverage between 0 and 100, now I think this is definetly a breaking change. What do you think?

I personally don't think this is a breaking change since specifying min_coverage smaller than 0 or greater than 100 was incorrect usage. However, perhaps a less "breaking" solution would be to clamp the values instead of throwing an error, but that might be less intuitive. Either way, I'm fine with both approaches.

@kelvinwieth

Copy link
Copy Markdown
Contributor Author

@alestiago can you add the hacktoberfest tag?

@alestiago

Copy link
Copy Markdown
Contributor

@kelvinwieth I'm not sure how do you want me to do so. Unfortunately this year we didn't prepare to participate in Hacktoberfest (hopefully next year we do!).

@alestiago

alestiago commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

@erickzanardo @renancaraujo @wolfenrain can I get an additional review here?

@alestiago alestiago merged commit d17dc51 into VeryGoodOpenSource:main Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants