fix: min_coverage parsing with default to 100#290
Conversation
|
This may be a breaking change. The current behavior is |
alestiago
left a comment
There was a problem hiding this comment.
LGTM! Thank you for working on this! 💙
|
@alestiago with the addition of |
I personally don't think this is a breaking change since specifying min_coverage smaller than 0 or greater than 100 was incorrect usage. However, perhaps a less "breaking" solution would be to clamp the values instead of throwing an error, but that might be less intuitive. Either way, I'm fine with both approaches. |
|
@alestiago can you add the hacktoberfest tag? |
|
@kelvinwieth I'm not sure how do you want me to do so. Unfortunately this year we didn't prepare to participate in Hacktoberfest (hopefully next year we do!). |
|
@erickzanardo @renancaraujo @wolfenrain can I get an additional review here? |
Description
Following the conversation on #287, this PR:
min_coveragedefaults to100, which is a requirement but the behavior is missingmin_coverageto be between 0 and 100.Type of Change