Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: avoid reporting NaN coverage#237

Merged
alestiago merged 3 commits into
mainfrom
fix/NaN-coverage
Mar 16, 2023
Merged

fix: avoid reporting NaN coverage#237
alestiago merged 3 commits into
mainfrom
fix/NaN-coverage

Conversation

@alestiago

@alestiago alestiago commented Mar 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

When the total finds is 0 a division by 0 is performed throwing a NaN error.

# Before
NaN is less than min_coverage 100

# After
0 is less than min_coverage 100

Partially related to #146.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago changed the title fix: reporting NaN coverage fix: avoid reporting NaN coverage Mar 16, 2023
@alestiago alestiago marked this pull request as ready for review March 16, 2023 12:12
@alestiago alestiago self-assigned this Mar 16, 2023
@alestiago alestiago merged commit c50a398 into main Mar 16, 2023
@alestiago alestiago deleted the fix/NaN-coverage branch March 16, 2023 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@felangel felangel Awaiting requested review from felangel

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

1 more reviewer

@renancaraujo renancaraujo renancaraujo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alestiago alestiago

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alestiago @renancaraujo