Skip to content

Release v1.2.14-1#618

Merged
Asherda merged 15 commits intoVerusCoin:masterfrom
Asherda:release-v1.2.14-1
Jan 17, 2026
Merged

Release v1.2.14-1#618
Asherda merged 15 commits intoVerusCoin:masterfrom
Asherda:release-v1.2.14-1

Conversation

@Asherda
Copy link
Copy Markdown

@Asherda Asherda commented Jan 17, 2026

No description provided.

miketout and others added 15 commits December 26, 2025 13:10
```ini
gen=1
genproclimit=1
mint=1
```

The daemon would:
1. Show `"numthreads": 0` in `getmininginfo`
2. Potentially hang on startup

However, manually running `./verus setgenerate true 1` after startup worked correctly.

The `komodo_args()` function runs **before** the configuration file is loaded.

In bitcoind.cpp:

| Line | Code | Description |
|------|------|-------------|
| 113 | `ParseParameters(argc, argv)` | Command-line args parsed |
| 142 | `komodo_args(argv[0])` | Sets `KOMODO_MININGTHREADS` |
| 161 | `ReadConfigFile(mapArgs, mapMultiArgs)` | **Config file loaded here** |

When `komodo_args()` executes (line 142), it checks for `-gen` in `komodo_utils.h:1746-1750`:

```cpp
if ( GetBoolArg("-gen", false) != 0 )
{
    KOMODO_MININGTHREADS = GetArg("-genproclimit",-1);
}
else KOMODO_MININGTHREADS = 0;
```

At this point, `mapArgs` only contains **command-line arguments**. Config file settings (`gen=1`, `genproclimit=1`, `mint=1`) haven't been loaded yet.

Since `-gen` isn't found, `KOMODO_MININGTHREADS` is set to `0` and never updated.

1. **Added `extern` declaration** for `KOMODO_MININGTHREADS` in init.cpp
2. **Set `KOMODO_MININGTHREADS`** in init.cpp after the config file has been read
3. **Moved `GenerateBitcoins()` call** to after `SetRPCWarmupFinished()` to ensure the node is fully initialized before starting mining threads

**init.cpp:**
- Added `extern int32_t KOMODO_MININGTHREADS;` declaration
- Set `KOMODO_MININGTHREADS` from config after it's loaded
- Deferred `GenerateBitcoins()` until after RPC warmup completes

---
Config args not being loaded from .conf file
Update version and deprecation height
@Asherda Asherda merged commit f6c146b into VerusCoin:master Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants