Skip to content

Release v1.2.5-2#590

Merged
Asherda merged 62 commits intoVerusCoin:masterfrom
Asherda:release-v1.2.5-2
Nov 4, 2024
Merged

Release v1.2.5-2#590
Asherda merged 62 commits intoVerusCoin:masterfrom
Asherda:release-v1.2.5-2

Conversation

@Asherda
Copy link
Copy Markdown

@Asherda Asherda commented Nov 4, 2024

No description provided.

Oink70 and others added 30 commits October 8, 2024 10:53
without that fix clang gives an error:

./mmr.h:143:35: error: overloaded operator >> has higher precedence than comparison operator [-Werror,-Woverloaded-shift-op-parentheses]
        assert(work << 128 >> 128 == work && stake << 128 >> 128 == stake);
               ~~~~~~~~~~~~~~~~~~ ^  ~~~~
./pbaas/vdxf.h:817:24: error: no matching constructor for initialization of 'uint256'
                salt = uint256(std::vector<unsigned char>(data.end() - sizeof(uint256)), data.end());
                       ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./uint256.h:119:5: note: candidate constructor not viable: requires single argument 'b', but 2 arguments were provided
    uint256(const base_blob<256>& b) : base_blob<256>(b) {}

It was accidentally separated data.end() - sizeof(uint256) and data.end() into two arguments instead of passing them as a range.

The fix creates a std::vector<unsigned char> from the range [data.end() - sizeof(uint256), data.end()).

The single std::vector is then passed to the uint256 constructor that takes a const std::vector<unsigned char>&, matching the expected constructor.
./pbaas/pbaas.h:1520:28: error: no matching constructor for initialization of 'COptCCParams'
    COptCCParams vParams = COptCCParams(COptCCParams::VERSION_V2, evalcode, 1, 2, vpk, vvch);
DeckerSU and others added 28 commits November 2, 2024 18:51
TODO: reconsider all of these flags
Manual invocation of internal functions like __tls_init() is not recommended and is typically unnecessary.
avoid this error:

src/tcp_address.cpp:132:12: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
    pos += sprintf (pos, "%d", ntohs (port_));
           ^

when building on with Apple clang version 14.0.3 (clang-1403.0.22.14.1)
older versions of rust will give error like this on modern osx and xcode:

b6f6b59b6a29ec3a.rlib(rust.metadata.bin), archive member 'rust.metadata.bin' with length 23385156 is not mach-o or llvm bitcode file '/Users/builder/verus-mac-build/depends/x86_64-apple-darwin22.5.0/native/lib/rustlib/x86_64-apple-darwin/lib/libcore-b6f6b59b6a29ec3a.rlib'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
build: mac, use native clang as default compiler
Add missing character in suggested command
…ERROR_SYSCALL, just close the socket.

(cherry picked from commit PirateNetwork/pirate/2cc900c1958e80f78e6bb754f59b1d759b496272)
(cherry picked from commit 69592fd198ed37949677dd4dde62e3d39a4a6700)
(cherry picked from commit 90848543ac853a53b5af0aaba223c0ba5def7473)
Set deprecation height and update version to v1.2.5-2
@Asherda Asherda merged commit 8a90ef3 into VerusCoin:master Nov 4, 2024
@Asherda Asherda deleted the release-v1.2.5-2 branch September 3, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants