Merged
Conversation
… VerusID with timelock set
without that fix clang gives an error:
./mmr.h:143:35: error: overloaded operator >> has higher precedence than comparison operator [-Werror,-Woverloaded-shift-op-parentheses]
assert(work << 128 >> 128 == work && stake << 128 >> 128 == stake);
~~~~~~~~~~~~~~~~~~ ^ ~~~~
./pbaas/vdxf.h:817:24: error: no matching constructor for initialization of 'uint256'
salt = uint256(std::vector<unsigned char>(data.end() - sizeof(uint256)), data.end());
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./uint256.h:119:5: note: candidate constructor not viable: requires single argument 'b', but 2 arguments were provided
uint256(const base_blob<256>& b) : base_blob<256>(b) {}
It was accidentally separated data.end() - sizeof(uint256) and data.end() into two arguments instead of passing them as a range.
The fix creates a std::vector<unsigned char> from the range [data.end() - sizeof(uint256), data.end()).
The single std::vector is then passed to the uint256 constructor that takes a const std::vector<unsigned char>&, matching the expected constructor.
before CRLPProof have only default ctor
./pbaas/pbaas.h:1520:28: error: no matching constructor for initialization of 'COptCCParams'
COptCCParams vParams = COptCCParams(COptCCParams::VERSION_V2, evalcode, 1, 2, vpk, vvch);
TODO: reconsider all of these flags
Manual invocation of internal functions like __tls_init() is not recommended and is typically unnecessary.
avoid this error:
src/tcp_address.cpp:132:12: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
pos += sprintf (pos, "%d", ntohs (port_));
^
when building on with Apple clang version 14.0.3 (clang-1403.0.22.14.1)
older versions of rust will give error like this on modern osx and xcode: b6f6b59b6a29ec3a.rlib(rust.metadata.bin), archive member 'rust.metadata.bin' with length 23385156 is not mach-o or llvm bitcode file '/Users/builder/verus-mac-build/depends/x86_64-apple-darwin22.5.0/native/lib/rustlib/x86_64-apple-darwin/lib/libcore-b6f6b59b6a29ec3a.rlib' clang: error: linker command failed with exit code 1 (use -v to see invocation)
build: mac, use native clang as default compiler
Add missing character in suggested command
Build patches
…ERROR_SYSCALL, just close the socket. (cherry picked from commit PirateNetwork/pirate/2cc900c1958e80f78e6bb754f59b1d759b496272)
(cherry picked from commit 69592fd198ed37949677dd4dde62e3d39a4a6700)
(cherry picked from commit 90848543ac853a53b5af0aaba223c0ba5def7473)
ARRR tls ports
depends: update dependencies.
Set deprecation height and update version to v1.2.5-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.