Refactor ProteinFinder.getProtein with many args#99
Merged
VerisimilitudeX merged 1 commit intoVerisimilitudeX:mainfrom Oct 2, 2022
Merged
Conversation
82176a4 to
0475571
Compare
Contributor
Author
|
@Verisimilitude11 Can you share Better Code Hub reports here ? |
VerisimilitudeX
requested changes
Oct 1, 2022
Owner
VerisimilitudeX
left a comment
There was a problem hiding this comment.
Changes look fine, I'll approve both of your PRs once you clear your other PR's conflict
Owner
|
Owner
|
I'll approve this as well once the conflicts are resolved. Thank for taking the time to contribute to DNAnalyzer! |
0475571 to
18303a4
Compare
Replace arraylist with list Add constructor for ProteinFinder class closes VerisimilitudeX#72
18303a4 to
070042a
Compare
Contributor
Author
Done |
VerisimilitudeX
approved these changes
Oct 2, 2022
Owner
VerisimilitudeX
left a comment
There was a problem hiding this comment.
Nice work! Thanks for taking care of the conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace arraylist with list
Add constructor for ProteinFinder class
closes #72