Condensed code in countBasePairs as to resolve #274#285
Merged
VerisimilitudeX merged 4 commits intoVerisimilitudeX:mainfrom Oct 31, 2022
Merged
Condensed code in countBasePairs as to resolve #274#285VerisimilitudeX merged 4 commits intoVerisimilitudeX:mainfrom
VerisimilitudeX merged 4 commits intoVerisimilitudeX:mainfrom
Conversation
Signed-off-by: garyglatfelter <51980155+garyglatfelter@users.noreply.github.com>
Owner
|
Looks good @garyglatfelter, I'll merge after some more testing tomorrow. |
VerisimilitudeX
approved these changes
Oct 31, 2022
Owner
VerisimilitudeX
left a comment
There was a problem hiding this comment.
Looks great @garyglatfelter! Do you want to get started on using parallel streams and more performance improvements soon?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Condensed stream function into 2 instead of 3. I thought 3 lines made it more readable, but I guess not good coding style? It fits in less than 15 lines now per guidelines. resolves #274