Refactorings of getAminoAcidMapping#243
Refactorings of getAminoAcidMapping#243VerisimilitudeX merged 11 commits intoVerisimilitudeX:mainfrom
Conversation
VerisimilitudeX
left a comment
There was a problem hiding this comment.
@Speedro looks like there are conflicts again. This PR is first in my backlog, so I'll review it once you clear the merge conflicts. Thanks!
| THREONINE("Theornine", "t", "threonine", "thr"), | ||
| VALINE("Valine", "v", "valine", "val"), | ||
| THRYPTOPHAN("Thryptophan", "w", "tryptophan", "trp"); | ||
| TRYPTOPHAN("Thryptophan", "w", "tryptophan", "trp"), |
There was a problem hiding this comment.
Remove "Thryptophan". I know you didn't put it there and I have no idea how it got there.
There was a problem hiding this comment.
Or actually, remove the h and leave it as an uppercase check.
There was a problem hiding this comment.
@Verisimilitude11 thanks, I resolved the conflicts and left the 'Tryptophan' inside the enum. Please check, if it's ok and let me know if not 🙂 🚀
63ebced to
c9d90ad
Compare
| * | ||
| * @author @Speedro | ||
| */ | ||
| public class CodonDataUtilsTest { |
There was a problem hiding this comment.
@Verisimilitude11 Ok, I am not sure about the CodeSceneDelta analyzis fail as the strings are valid inputs for the test case. Maybe this analyzis could be softened for test classes or something.
There was a problem hiding this comment.
Or the codon parts (ATT, ATC etc.) could be turned into String constants. Not sure if that helps though, but maybe could.
There was a problem hiding this comment.
Yeah don't worry about CodeScene, they don't have the most reliable reporting. I'll merge later tomorrow after some testing.
- updated junit version so we can use parametrized tests - created CodonDataUtilsTest class - deleted no longer used AminoAcidMapping.java and AminoAcidNames.java. - only AminoAcid.java enum should be used
c9d90ad to
0b00539
Compare
Signed-off-by: Piyush Acharya <acharyapiyush1@outlook.com>
closes #186