Refactor CmdArgs.run()#196
Merged
VerisimilitudeX merged 5 commits intoVerisimilitudeX:mainfrom Oct 17, 2022
ishche:main
Merged
Conversation
|
|
Owner
|
@ishche why did you close this PR? Is there anything I can do to help? |
Contributor
Author
|
@Verisimilitude11 oh, PR checks reported that refactoring is still needed. |
Owner
|
Don't worry about that, the checks aren't that accurate. |
Owner
|
I'll merge it after some testing later today. |
Owner
|
Could you please clear the conflicts? Thanks! |
Owner
|
Hey @ishche, I will be out of office for some time, so it will take me some time merge the pull request. However, I will approve the pull request in case you are participating in Hacktoberfest. Thanks for working on this, we at DNAnalyzer really appreciate your help! |
VerisimilitudeX
approved these changes
Oct 15, 2022
Signed-off-by: Piyush Acharya <acharyapiyush1@outlook.com>
Owner
|
@ishche could you please star this repository of you haven’t already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184