resolves #80: Refactor CoreExecutor.createProteinList(String,String)#101
Merged
VerisimilitudeX merged 2 commits intoVerisimilitudeX:mainfrom Oct 1, 2022
Conversation
Signed-off-by: Hrithik Raj <iamhrithikraj26@gmail.com>
Contributor
Author
|
resolved conflicts! |
VerisimilitudeX
requested changes
Oct 1, 2022
Owner
VerisimilitudeX
left a comment
There was a problem hiding this comment.
Looks good! Could you please fix the conflicts? Thanks!
Contributor
Author
done already |
Owner
Yes, sorry, I think you made the changes right when I was looking at it 😆. I'll do some testing quickly and will approve it! |
Owner
|
In the meantime, feel free to add yourself as an @author to the methods that you changed/added! |
Contributor
Author
appreciate it bro, but it's fine it was a minor refactoring after all :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
CoreExecutor.createProteinList(String,String).Removed the logic of passing down the amino acids as args to the
getProtein(String, String)function and useCodonData.getAminoAcid()ingetProtein(String, String)itself for better encapsulation.