Skip to content

Fix for using library as a transative dep #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SimonCropp merged 1 commit into from
Nov 14, 2020
Merged

Fix for using library as a transative dep #71

SimonCropp merged 1 commit into from
Nov 14, 2020

Conversation

@slang25
Copy link
Contributor

@slang25 slang25 commented Nov 14, 2020

See shouldly/shouldly#717

I've tested this locally by hacking about with my .nuget/packages folder, it seems to do the trick but could use another pair of eyes.

I've also removed buildMultiTargeting here, as I don't think we need to do an "outer build" import, we only want to operate at a per-tfm basis.

@slang25 slang25 mentioned this pull request Nov 14, 2020
Closed
@SimonCropp
Copy link
Member

SimonCropp commented Nov 14, 2020

Thanks for this. i will deploy and smoke test

@SimonCropp SimonCropp added this to the 2.3.1 milestone Nov 14, 2020
@SimonCropp SimonCropp merged commit df90548 into VerifyTests:master Nov 14, 2020
@SimonCropp SimonCropp added the Bug label Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Milestone

2.3.1

Development

Successfully merging this pull request may close these issues.

2 participants

@slang25 @SimonCropp