Run automated fixes on Pull Request#220
Merged
Venomalia merged 2 commits intoVenomalia:mainfrom Feb 23, 2024
Merged
Conversation
Merged
98c6780 to
b9fd734
Compare
Owner
|
I am not a fan of formatting the json files, otherwise i don't see any problems and it would be a good thing to have, thanks for making the effort |
Contributor
Author
|
I'll see if I can, otherwise I'll just omit the formatter or use a different one. Indent fixes are still relevant though. I prefered showing you the possibility/difference it makes, then reverting if disliked. |
Contributor
Author
|
@Venomalia The joys of an overly-opinionated formatter ^^ I excluded JSON files from the prettier hook and added a json formatting hook provided by pre-commit directly. |
Owner
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #217 . If this is accepted, the next step would be to sign-in on https://pre-commit.ci/ and connect it to this repo. (it's the CI autofixes version of https://pre-commit.com) .
Added autoformatting and basic linting fixes for YAML, JSON, Markdown and Python files.
As well as autofixes for mixed-line-ending, case-conflict trailing whitespaces and end-of-file newline.
You can run locally using:
pip install pre-committo installpre-commit runto runYou can run on all files using
pre-commit run --all-files(see #221 for an initial run on all files)Devs who enjoy pre-commit git hooks (I don't, some do), can also now use this as a pre-commit hook on their own accord using
pre-commit installExample run:
