Add Pitfall: The Lost Expedition / The Big Adventure#171
Merged
Venomalia merged 1 commit intoVenomalia:mainfrom Mar 8, 2024
Merged
Add Pitfall: The Lost Expedition / The Big Adventure#171Venomalia merged 1 commit intoVenomalia:mainfrom
Venomalia merged 1 commit intoVenomalia:mainfrom
Conversation
9d1a571 to
5d89280
Compare
Contributor
Author
|
Converted to draft until #222 is completed. Then I'll need to update the json files to the updated templates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first version, I'd like to also add the following in the future:
For the bidirectional stick inputs to work, I simply kept the original masks, and used neutral stick for the base texture. This is also more in-line with the game's style. It makes the joystick appear a bit faded, but imo it's more than fine. A custom mask could fix that, but that would be done with my first point above when adding other custom styles / device textures.
Edit note: I the latest version of this PR, the Left joystick is slightly different. It looked better using the "Flat Pressed" version, but I'm fine avoiding generating those just for 1 icon.

Demonstration