FLAC: Add appendOnly option for FlaxMuxer, fix FlacDemuxer reading it#325
Merged
Vanilagy merged 8 commits intoVanilagy:mainfrom Mar 19, 2026
Merged
FLAC: Add appendOnly option for FlaxMuxer, fix FlacDemuxer reading it#325Vanilagy merged 8 commits intoVanilagy:mainfrom
appendOnly option for FlaxMuxer, fix FlacDemuxer reading it#325Vanilagy merged 8 commits intoVanilagy:mainfrom
Conversation
JonnyBurger
commented
Mar 17, 2026
| const slice = await this.reader.requestSliceRange( | ||
| startPos, | ||
| this.audioInfo.minimumFrameSize, | ||
| maximumHeaderLength, |
Contributor
Author
There was a problem hiding this comment.
Small optimization I figured: here we just wanna read the header, so we need at least maximumHeaderSize bytes, which will be lower than this.audioInfo.minimumFrameSize most of the times.
Vanilagy
approved these changes
Mar 19, 2026
Owner
|
Very nice, thank you! Looks clean to me. Wasn't there an issue related to this feature? I can't for the life of me find it!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample file generated: sample-append-only.zip (rename extension to .flac, since GitHub does not support .flac file extension)
appendOnlyoption which writesminimumFrameSize = 16,maximumFrameSize = 65535,minimumBlockSize = 0,maximumBlockSize = 0. Spec allows setting0as unknown for block sizes, but not for frame sizes. But frame sizes are 16-bit (Spec: 8.2 Streaminfo)This discovered that the demuxer does not handle
maximumBlockSize = 0.I fixed it as well, and added links to the spec to back up the reason for the values chosen.