Skip to content

feat(chat): add skill preview functionality in chat input and enhance localization support#984

Merged
hazeone merged 1 commit intomainfrom
feat/support_preview_chosen_skill
May 7, 2026
Merged

feat(chat): add skill preview functionality in chat input and enhance localization support#984
hazeone merged 1 commit intomainfrom
feat/support_preview_chosen_skill

Conversation

@hazeone
Copy link
Copy Markdown
Contributor

@hazeone hazeone commented May 7, 2026

Summary

image

Related Issue(s)

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other

Validation

Checklist

  • I ran relevant checks/tests locally.
  • I updated docs if behavior or interfaces changed.
  • I verified there are no unrelated changes in this PR.

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0429ada23

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

}
chunks.push(
<span
<button
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep skill preview controls out of the hidden overlay

When the composer contains a skill token, this focusable button is rendered inside the overlay that is marked aria-hidden="true" at the call site. Keyboard and assistive-technology users can still tab to the token button, but screen readers will not expose its name or action, making the new SKILL.md preview control effectively inaccessible in that scenario; make the clickable control part of the accessibility tree or provide an equivalent non-hidden control.

Useful? React with 👍 / 👎.

@hazeone hazeone merged commit 35ae535 into main May 7, 2026
5 checks passed
@hazeone hazeone deleted the feat/support_preview_chosen_skill branch May 7, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant