Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 464fd1f08a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return spawn(ELECTRON_BUILDER_BIN, args, { | ||
| cwd: ROOT, | ||
| stdio: 'inherit', | ||
| env: process.env, | ||
| shell: process.platform === 'win32', |
There was a problem hiding this comment.
Quote Windows electron-builder command before shell spawn
When process.platform === 'win32', this calls spawn(ELECTRON_BUILDER_BIN, args, { shell: true }) with an unquoted absolute .cmd path. Under Windows shells, .cmd invocations with spaces in the script path (for example, a checkout under C:\Users\First Last\...) are tokenized by cmd.exe and fail to execute, so package:win/release can break on common developer machines. Node’s child_process guidance for .cmd with shell: true requires quoting the command path; otherwise builds can fail before electron-builder starts.
Useful? React with 👍 / 👎.
No description provided.